-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the schema files to v3.0.1 #426
Conversation
This adapts the schema files to version 3.0.1 of the specification. However, this is not an official release yet and may be subject to change.
@s-heppner what is the state here? Please ping me when I can re-review this PR again. |
Currently, the regex for Path type is non-compliant to the specification v3.0, as it does not allow for AASX packages to be written. As a temporary bugfix in v3.0.1, it was decided to remove the invariant check, as changing the pattern would result in a breaking change. This is of course no final solution, there will be a better fix for version 3.1. See #299
@sebbader-sap You can use the now updated version for the API generation, however we still need to run the tests and generate the example files, before I will mark this PR as ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aas-specs/schemas/json/aas.json
Line 44 in b0e3e73
"pattern": "^([\\t\\n\\r -\ud7ff\ue000-\ufffd]|\\ud800[\\udc00-\\udfff]|[\\ud801-\\udbfe][\\udc00-\\udfff]|\\udbff[\\udc00-\\udfff])*$" |
This should be resolved now. Can you please check again? |
@s-heppner the current state looks good for me, just two last questions:
|
ad 1.) The zero is optional in regexes, see this comment ad 2.) From all I can tell, this regex is fine and generally the spaces shouldn't place problems. Please wait with the release until I was able to run the schema generation one last time, since we found one last issue: aas-core-works/aas-core-codegen#494 |
Previously, the metamodel version was not clear from the generated JSON schema. We adapt the title to include the version.
I regenerated the JSON Schema and confirmed that there are no other effects of aas-core-works/aas-core-codegen#494. Therefore, this is now ready for release, as far as I'm converned |
@BirgitBoss I can confirm Sebastian's statement on the "contentType" regex. I just finished a bunch of tests and now agree that the pattern is working accordingly. |
This adapts the schema files to version 3.0.1
of the specification.
However, this is not an official release yet
and may be subject to change.
This is only meant as reference for the
API specification.