-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WCM Core Email components added for v6.5 #397
Open
knennigtri
wants to merge
9
commits into
adobe:main
Choose a base branch
from
knennigtri:wknd-email-cmps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@knennigtri This is great, however instead of a new submodule (email) can this be a separate project like WKND Shared. This will help to have decoupling and somewhat independent development, and release cycle. |
@SachinMali this makes sense, I'll just need a bit of guidance (official repo, publishing to maven, etc...) on how to do that. |
@knennigtri Thanks and sorry for the delay. Please see high-level steps
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New submodule called
/email
for POC for email pages for ACC/ACS using AEM v6.5.x/apps/wknd/components/email
/apps/wknd/clientlibs/clientlib-email
/apps/wknd/config/rewriter/email-link-rewrite
(core email cmps project said this was required)/content/campaigns/wknd/master/campaign-emails/wknd-email
/conf/wknd/settings/wcm/templates/email-page
/conf/wknd/settings/wcm/template-types/email-page
/conf/wknd/settings/wcm/policies/wknd/components/email
Feature request: #396
Motivation and Context
Core Email Components are now supported with WCM Core Components v2.21.2. Adobe gives good documentation for them, but a good example is lacking. Using WKND's brand to highlight these components helps developers investigate the components and gain interest.
How Has This Been Tested?
Core email components 1.0.0 requires AEM 6.5.14+ and Core Components v2.21.2
AEM 6.5.14 with this project integrated with ACS successfully sent the email page from AEM to ACS.
AEM >> ACC has not been tested
Screenshots (if appropriate):
The example email tries to highlight some of the new WCM Email Core components as well as maintaining the basic layout of the original examples that existed with the We.Retail example.
Types of changes
Checklist: