Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge staging v2.x into main-v2.x for Assurance 2.2.2 #144

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

prudrabhat
Copy link
Contributor

Description

Merge staging v2.x into main-v2.x for Assurance 2.2.2
Key Changes:

Release Notes

- Fixed an issue causing incorrect application details being sent in the `client` event.

Related Issue

MOB-21662

How Has This Been Tested?

  • Unit tests
  • Smoke testing staging build on Android 14, Android 13

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

prudrabhat and others added 8 commits October 21, 2024 14:11
We are seeing occasional instances where the app AndroidManifest content being
sent by the Assurance SDK as part of client event is not the actual manifest
of the app- and it is for the WebView library.

Currently this is being seen in Android 15 physical device and automation tests
and we have not be able to root cause this issue but it seems to be some case of
bad android manifest read from the system itself.

Given that the package name can be programmatically retrieved (as opposed to the current way
of reading the entire manifest), this change adds a device side detection of this wrong
package name scenario and then force correct it on device before sending the
client event as a best effort these cases.

This PR also changes the tests to Kotlin from Java for AssuranceClientInfo
[MOB-21662] Validate and fallback to known manifest (2.x)
Merge `dev-v2.x` into `staging-v2.x` for Assurance 2.2.2
@prudrabhat prudrabhat requested a review from praveek October 29, 2024 00:00
@prudrabhat prudrabhat merged commit 9bb78bd into main-v2.x Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants