Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcase all keys before storing in .env #797

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

purplecabbage
Copy link
Member

Description

Related Issue

Confusing lowercase .env keys adobe/aio-cli

I have not updated the tests as this really just means upcasing all the fixtures and I want to be sure there are no unexpected side-effects before heavy handedly making the tests pass.

Motivation and Context

I was confused ... I still am about this key:
AIO_ims_contexts_Credential__in__Jesse__Is__Back__-__Stage_client__id

- is not valid in an identifier/property name, so this becomes:
( note the ticks )

  AIO_RUNTIME_APIHOST: 'https://adobeioruntime.net',
  'AIO_IMS_CONTEXTS_CREDENTIAL__IN__JESSE__IS__BACK__-__STAGE_CLIENT__ID': ...

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron
Copy link
Member

shazron commented May 14, 2024

tests are now failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants