Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto references & attribute set/get #461

Merged
merged 6 commits into from
Nov 26, 2024
Merged

feat: auto references & attribute set/get #461

merged 6 commits into from
Nov 26, 2024

Conversation

solaris007
Copy link
Member

@solaris007 solaris007 commented Nov 25, 2024 •
edited
Loading

  • Declare model associations (references) in schema
  • Resolve and cache references
  • Auto-create reference getters based on schema
  • Auto-create attribute getters & setters based on schema
  • Fix schema attribute validation

@solaris007 solaris007 added the enhancement New feature or request label Nov 25, 2024
@solaris007 solaris007 requested a review from chicharr November 25, 2024 15:19
@solaris007 solaris007 self-assigned this Nov 25, 2024
@github-actions GitHub Actions
Copy link

This PR will trigger a minor release when merged.

@solaris007
Copy link
Member Author

Opened tywalch/electrodb#449 to improve validation vs required check.

@solaris007 solaris007 changed the title feat: better reference tracking feat: auto references & attribute set/get Nov 26, 2024
@solaris007 solaris007 requested a review from dzehnder November 26, 2024 08:51
dzehnder
dzehnder approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@dzehnder dzehnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solaris007 solaris007 merged commit 2c29683 into main Nov 26, 2024
9 checks passed
@solaris007 solaris007 deleted the feat-references-tracking branch November 26, 2024 09:10
adobe-bot pushed a commit that referenced this pull request Nov 26, 2024
@semantic-release-bot
chore(release): 1.58.0 [skip ci]
15372a8 
# [@adobe/spacecat-shared-data-access-v1.58.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.57.2...@adobe/spacecat-shared-data-access-v1.58.0) (2024-11-26)

### Features

* auto references & attribute set/get ([#461](#461)) ([2c29683](2c29683))
@adobe-bot
Copy link

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzehnder dzehnder dzehnder approved these changes

@chicharr chicharr Awaiting requested review from chicharr

@alinarublea alinarublea Awaiting requested review from alinarublea

Assignees

@solaris007 solaris007

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solaris007 @adobe-bot @dzehnder