Additional logging for ODD notifications (#38)

adobe · Sep 7, 2023 · 550bd60 · 550bd60
1 parent 3056747
commit 550bd60
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/Source/Adobe.Target.Client/Service/OnDeviceDecisioningService.cs b/Source/Adobe.Target.Client/Service/OnDeviceDecisioningService.cs
@@ -87,6 +87,7 @@ public TargetDeliveryResponse ExecuteRequest(TargetDeliveryRequest deliveryReque
             var ruleSet = this.ruleLoader.GetLatestRules();
             if (ruleSet == null)
             {
+                TargetClient.Logger?.LogWarning("Decisioning rules not loaded, returning empty response");
                 var deliveryResponse = new DeliveryResponse(
                     (int)HttpStatusCode.ServiceUnavailable,
                     deliveryRequest.DeliveryRequest.RequestId,
@@ -203,11 +204,16 @@ private void HandleDetails(
 
         private void SendNotifications(TargetDeliveryRequest request, TargetDeliveryResponse targetResponse, List<Notification> notifications, TelemetryEntry telemetryEntry)
         {
+            TargetClient.Logger?.LogDebug("Sending notifications for requestId: {requestId} sessionId: {sessionId}", request.DeliveryRequest.RequestId, request.SessionId);
+
             if (notifications.Count == 0 && telemetryEntry == null)
             {
+                TargetClient.Logger?.LogDebug("No notifications to send");
                 return;
             }
 
+            TargetClient.Logger?.LogDebug("Notifications: {notifications}", string.Join(", ", notifications));
+
             var deliveryRequest = request.DeliveryRequest;
             var locationHint = request.LocationHint ?? this.clusterLocator.GetLocationHint();
             var telemetry = telemetryEntry != null ? new Telemetry(new List<TelemetryEntry> { telemetryEntry }) : null;

diff --git a/Source/Adobe.Target.Client/Service/TargetService.cs b/Source/Adobe.Target.Client/Service/TargetService.cs
@@ -112,6 +112,7 @@ private TargetDeliveryResponse GetTargetDeliveryResponse(TargetDeliveryRequest r
         {
             if (response == null)
             {
+                this.logger?.LogWarning("Null response for requestId: {requestId}, sessionId: {sessionId}", request.DeliveryRequest.RequestId, request.SessionId);
                 return new TargetDeliveryResponse(request, null, HttpStatusCode.ServiceUnavailable);
             }