Add back activesupport #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 29 29
Lines 766 767 +1
=======================================
+ Hits 762 763 +1
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adomokos
force-pushed
the
ad/add-back-active-support
branch
from
5263863 to
5994bb4
Compare
We are not ready to remove it. There are instances of `blank?` and `singularize` that are used in the code. Removing `activesupport` still not fails any of the tests, as we have `generator_spec` that uses and installs `activesupport`.
adomokos
force-pushed
the
ad/add-back-active-support
branch
from
5994bb4 to
5047cfe
Compare
|
Addresses #260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not ready to remove it. There are instances of
blank?andsingularizethat are used in the code.Removing
activesupportstill not fails any of the tests, as we havegenerator_specthat uses and installsactivesupport.Fixes #257 and #258.