Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling skipped modes to LL2 tests for AIX and Linux Platform #459

Closed
wants to merge 7 commits into from

Conversation

Edith-Mercy
Copy link

github.ibm.com/runtimes/backlog/issues/1107 - with ref. to the backlog issue made changes to verify that skipped tests are executed

The Skipped modes that is enabled are
109-CS,110-CS, 150-CS,159-CS,301,350,351,501,503,504,506,507,550,551,555,556,557,601,609,610,615,688.

hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6015/ - aix_ppc
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6009/ - aix_ppc-64
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6007/ - linux_x86-64
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6008/ - linux_ppc
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6010/ - linux_ppc-64
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6011/ - linux_ppc-64_le
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6013/ - s390x_linux
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/6043 - linux_x86
hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/5079 - s390_linux

@Edith-Mercy
Copy link
Author

@llxia Can you review this Pull request to merge the changes?

@llxia llxia requested a review from renfeiw July 26, 2023 12:40
@llxia
Copy link
Contributor

llxia commented Jul 26, 2023

If we enable for mixed, then either nocmprssptrs or cmprssptrs should be also enabled.

@llxia
Copy link
Contributor

llxia commented Jul 27, 2023

@renfeiw could you also review this PR?

@renfeiw
Copy link
Contributor

renfeiw commented Jul 27, 2023

@Edith-Mercy Could you please address this comment:

If we enable for mixed, then either nocmprssptrs or cmprssptrs should be also enabled.

@Edith-Mercy
Copy link
Author

@llxia For nocmprssptrs or cmprssptrs enabling the modes in ottawa.csv is the first step as per my understanding, however, I'm not sure how to test these on jenkins runs (like what options or PLATFORM need to be specified to start the runs on these modes), Can you help me on the same..

@karianna karianna requested a review from llxia June 23, 2024 01:50
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • -Xgcpolicy:metronome is not supported on zLinux. From a brief look, this PR enabled it on zLinux. Also, there is no testing on windows. Both show that this PR has not been fully tested.
  • This PR is similar to LL4 playlist migration #527. Please explain.

@karianna karianna requested a review from llxia November 22, 2024 08:13
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s unnecessary to request the review again without first addressing the concerns. Also, reiterate #582 (review)

@Edith-Mercy Edith-Mercy deleted the LL2_skipped_modes branch November 28, 2024 10:22
@Edith-Mercy
Copy link
Author

@llxia PRs to enable modes for #582 and #527 are merged into this PR

@llxia
Copy link
Contributor

llxia commented Dec 11, 2024

@Edith-Mercy Thanks for working on this. But you closed this PR and deleted the LL2_skipped_modes branch 2 weeks ago, please open a new one.

@Edith-Mercy
Copy link
Author

@llxia #650 created new pull request

@llxia llxia mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants