Export LIB_DIR #481
Export LIB_DIR #481
Conversation
Signed-off-by: Sophia Guo <[email protected]>
|
I think this should work in the github runner environment, but hard to test unless it's merged. |
| @@ -41,8 +41,7 @@ endif | |||
| ifeq ($(CYGWIN),1) | |||
| LIB_DIR:=$(shell cygpath -w $(LIB_DIR)) | |||
| endif | |||
| LIB_DIR:=$(subst \,/,$(LIB_DIR)) | |||
|
|
|||
| export LIB_DIR:=$(subst \,/,$(LIB_DIR)) | |||
There was a problem hiding this comment.
It is not recommended to change values and export in one cmd. Please separate the code into two lines.
There was a problem hiding this comment.
I'm just trying to keep the same style
Line 22 in 4c1094f
|
Could you test this change locally and provide console output? Thanks |
|
@LongyuZhang mentioned adoptium/aqa-tests#4914 is also the cause of external tests ( using docker image) failures hyc-runtimes-grinder 36901, this PR combined the former one fix the issue grinder hyc-runtimes-grinder 36903. The external functional tests is the environments similar to locals without jenkins environment set up. |
|
More details about the above mentioned external tests, inside docker, we run functional tests similar to local test, hyc-grinder 36901 failed since no lib_dir, while hyc-grinder 36903 passed with this PR. |
|
@llxia Grinders to avoid possible pipeline broken |
Fix adoptium/aqa-tests#4914