-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude tests with known issues #3231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sophia-guo !
If this PR is going to close #3230, then we should not reference #3230 in the disable comment.
This creates a loop where a disabled test is referencing a closed issue. It will create problem for disabled test pipeline in the future. |
system/security/playlist.xml
Outdated
<versions> | ||
<version>8</version> | ||
<version>11</version> | ||
</versions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a temporary exclusion? If so, please use disable feature and reference the open issue. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick answer is we don't know. @joeyleeeeeee97 could probably confirm that adoptium/aqa-systemtest#474
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sophia-guo could we use disable feature and reference adoptium/aqa-systemtest#474 for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is a good approach as this is a temporary exclusion based on joeyleeeeeee97's reply
and I guess this is really only going to exclude in nightlies running off master... after we review the other triaged test, we could consider pushing exclusions to the v0.8.0-release branch |
Signed-off-by: Sophia Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sophia-guo
Signed-off-by: Sophia Guo <[email protected]>
Signed-off-by: Sophia Guo [email protected]