-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude tests with known issues for jdk17 #3821
Conversation
adoptium#3806 Signed-off-by: Sophia Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There are several re-inclusion in this PR. Are they intended? |
@llxia I'm not sure what do you mean by 're-inclusion', could you point me to the problematic line? |
@@ -99,8 +99,8 @@ sun/security/krb5/auto/rcache_usemd5.sh https://bugs.openjdk.java.net/browse/JDK | |||
############################################################################ | |||
|
|||
# jdk_other | |||
com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x | |||
com/sun/jndi/ldap/LdapPoolTimeoutTest.java https://github.com/adoptium/aqa-tests/issues/3619 windows-all | |||
#com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this line as com/sun/jndi/dns/ConfigTests/Timeout.java
is excluded in line104.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks @llxia. Yes, those duplicate lines are left on purpose by comment out. This way it's easy to track the test case issue if the issue is different with different os-arch.
@@ -101,8 +101,8 @@ sun/management/jdp/JdpSpecificAddressTest.java https://github.com/adoptium/aqa-t | |||
############################################################################ | |||
|
|||
# jdk_other | |||
com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x | |||
com/sun/jndi/ldap/LdapPoolTimeoutTest.java https://github.com/adoptium/aqa-tests/issues/3619 windows-all | |||
#com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. com/sun/jndi/dns/ConfigTests/Timeout.java is excluded in line106.
@@ -114,7 +114,7 @@ sun/management/jdp/JdpSpecificAddressTest.java https://github.com/adoptium/aqa-t | |||
############################################################################ | |||
|
|||
# jdk_other | |||
com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x | |||
#com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
com/sun/jndi/dns/ConfigTests/Timeout.java is excluded in the line below.
@@ -115,7 +115,7 @@ sun/management/jdp/JdpSpecificAddressTest.java https://github.com/adoptium/aqa-t | |||
############################################################################ | |||
|
|||
# jdk_other | |||
com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x | |||
#com/sun/jndi/dns/ConfigTests/Timeout.java https://github.com/adoptium/aqa-tests/issues/2876 linux-s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
com/sun/jndi/dns/ConfigTests/Timeout.java is excluded in the line below.
close #3806
Signed-off-by: Sophia Guo [email protected]