-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable aqavit-test in alpine-linux container(#4625) #4626
base: master
Are you sure you want to change the base?
Enable aqavit-test in alpine-linux container(#4625) #4626
Conversation
ac177fb
to
73519cc
Compare
73519cc
to
5b43098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we begin to add more and more of these examples of using containers instead of agents, we need to parameterize some things. For certain, we need to parameterize the image being used.
Instead of doing each platform individually, riscv and alpine-linux and whatever is next, we need to design the change to allow for us to do this with any platform where containers are supported, and be able to pass in an image or file that suits the purpose.
What kind of parameterization do you expect? Does it refer to the container images selected and used according to various configurations on nodes of a specific architecture? But like riscv involves qemu and two images, I feel that its execution method will not be too different from the current one. |
Parameterizing image and args, instead of hardcoding to alibabadragonwelljdk images I am going to have a discussion with @sophia-guo and @llxia - it relates to broadening support for this for all platforms that can support containers and also relates to my desire to investigate the use of Testcontainers. |
All right. Looking forward to the outcome of your discussion |
No description provided.