Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ProblemList_openjdk21.txt for Microsoft #4787

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

gdams
Copy link
Member

@gdams gdams commented Sep 26, 2023

We noticed this was missing so I've copied the Adoptium problem list. Not sure if I need to copy this to other vendor directories too?

@sophia-guo
Copy link
Contributor

Yes, the problem list is needed per jdk version for all vendors. However, if there are no specific tests need to be excluded per vendor an empty problem list file as a placeholder should be enough.

@gdams
Copy link
Member Author

gdams commented Sep 26, 2023

@sophia-guo updated PTAL

@smlambert
Copy link
Contributor

@sophia-guo - I was not aware that the vendor problem list file was actually needed, I thought it was used if it is there and not used if not present.

@smlambert smlambert merged commit d6373e7 into adoptium:master Sep 26, 2023
@sophia-guo
Copy link
Contributor

I was not aware that the vendor problem list file was actually needed, I thought it was used if it is there and not used if not present.

We can definitely enhance this.

@gdams gdams deleted the problemlist branch September 27, 2023 12:47
@gdams
Copy link
Member Author

gdams commented Sep 27, 2023

@sophia-guo - I was not aware that the vendor problem list file was actually needed, I thought it was used if it is there and not used if not present.

Yeah it currently produces an error if it doesn't exist

@sophia-guo
Copy link
Contributor

Issue address this. #4790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants