Move vendor repo logic in getVendorTestMaterial() #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vendor repo logic is in getFunctionalTestMaterial(). If CLONE_OPENJ9 = false, then vendor repo material will not be cloned. Move vendor repo logic in another function getVendorTestMaterial(). Clone vendor repo if VENDOR_REPOS is not empty. Signed-off-by: Lan Xia <[email protected]>
karianna
approved these changes
Oct 17, 2023
llxia
added a commit
to llxia/aqa-tests
that referenced
this pull request
Nov 22, 2023
The vendor repo logic is in getFunctionalTestMaterial(). If CLONE_OPENJ9 = false, then vendor repo material will not be cloned. Move vendor repo logic in another function getVendorTestMaterial(). Clone vendor repo if VENDOR_REPOS is not empty. Signed-off-by: Lan Xia <[email protected]>
llxia
added a commit
to llxia/aqa-tests
that referenced
this pull request
Nov 22, 2023
The vendor repo logic is in getFunctionalTestMaterial(). If CLONE_OPENJ9 = false, then vendor repo material will not be cloned. Move vendor repo logic in another function getVendorTestMaterial(). Clone vendor repo if VENDOR_REPOS is not empty. Signed-off-by: Lan Xia <[email protected]>
pshipton
pushed a commit
that referenced
this pull request
Nov 22, 2023
The vendor repo logic is in getFunctionalTestMaterial(). If CLONE_OPENJ9 = false, then vendor repo material will not be cloned. Move vendor repo logic in another function getVendorTestMaterial(). Clone vendor repo if VENDOR_REPOS is not empty. Signed-off-by: Lan Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendor repo logic is in getFunctionalTestMaterial().
If CLONE_OPENJ9 = false, then vendor repo material will not be cloned.
Move vendor repo logic in a new function getVendorTestMaterial().
Clone vendor repo if VENDOR_REPOS is not empty.
Related: #4810