Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable VThreadStackRefTest.java #4847

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Enable VThreadStackRefTest.java #4847

merged 1 commit into from
Nov 2, 2023

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS
Copy link
Contributor Author

fengxue-IS commented Nov 1, 2023 •
edited
Loading

Personal grinder verified test pass on JDK21: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/35784/

JasonFengJ9
JasonFengJ9 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Nov 1, 2023

Waiting for the ECA check to pass.

@llxia
Copy link
Contributor

llxia commented Nov 2, 2023

According to https://api.eclipse.org/git/eca/status/gh/adoptium/aqa-tests/4847, ECA passed

image

However, the ECA check in the PR still shows Pending — Eclipse Foundation Contributor Agreement validation is in progress..
I tried to click on Revalidate in the eclipse link, but it did not help.

@smlambert do you know what we should do in this case?

@smlambert
Copy link
Contributor

We can either raise a helpdesk issue to resolve (probably the best approach, as then EF can see how/why its hung), or try with a new push to this PR or a new PR.

@llxia
Copy link
Contributor

llxia commented Nov 2, 2023

@fengxue-IS do you mind trying with a new push to this PR or a new PR? If it does not work, I will raise a helpdesk issue with Eclipse.

@fengxue-IS
Copy link
Contributor Author

@llxia ECA passed, not sure what went wrong previously 😢

@smlambert smlambert merged commit e730d4f into adoptium:master Nov 2, 2023
llxia pushed a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
@fengxue-IS @llxia
Enable VThreadStackRefTest.java (adoptium#4847)
cabce25 
Signed-off-by: Jack Lu <[email protected]>
llxia pushed a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
@fengxue-IS @llxia
Enable VThreadStackRefTest.java (adoptium#4847)
5a80bc3 
Signed-off-by: Jack Lu <[email protected]>
pshipton pushed a commit that referenced this pull request Nov 22, 2023
@fengxue-IS @pshipton
Enable VThreadStackRefTest.java (#4847)
f3b0edd 
Signed-off-by: Jack Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@fengxue-IS @llxia @smlambert @JasonFengJ9