Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FIPS multi-version openjdk exclude #4905

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

LongyuZhang
Copy link
Contributor

Need to merge together with PRs:
ibmruntimes/openj9-openjdk-jdk#709
ibmruntimes/openj9-openjdk-jdk21#88
ibmruntimes/openj9-openjdk-jdk17#293
ibmruntimes/openj9-openjdk-jdk11#738
ibmruntimes/openj9-openjdk-jdk8#721

  • Add support for FIPS multi-version openjdk exclude
  • Related Issue: Runtimes_backlog/1272 1188

@LongyuZhang LongyuZhang requested a review from llxia December 6, 2023 16:03
@LongyuZhang
Copy link
Contributor Author

LongyuZhang commented Dec 6, 2023

Test Link:
hyc_grinder 36662
14:04:22 -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList.txt"
14:04:22 -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/excludes/ProblemList_openjdk17-openj9.txt"
14:04:22 -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList-FIPS140_2.txt" \

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from JasonFengJ9 December 6, 2023 16:22
@llxia
Copy link
Contributor

llxia commented Dec 6, 2023

related: #4900

@JasonFengJ9
Copy link
Contributor

#4905 (comment)
The grinder failed to find ProblemList-FIPS140_2.txt.

12:32:33  Error: Bad parameters specified: One of the files you specified was not found. The error reported was:
12:32:33  /home/jenkins/workspace/Grinder/aqa-tests/openjdk/openjdk-jdk/test/jdk/ProblemList-FIPS140_2.txt (No such file or directory)
12:32:33  -----------------------------------
12:32:33  jdk_math_1_FAILED

@llxia
Copy link
Contributor

llxia commented Dec 6, 2023

@LongyuZhang please sepcify your JDK_REPO/JDK_BRANCH in your Grinder. The default repo does not have your extension repo change

@LongyuZhang
Copy link
Contributor Author

LongyuZhang commented Dec 6, 2023

Updated the test link to hyc_grinder 36664.
It passed with the following output:

14:04:22  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList.txt" \
14:04:22  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/excludes/ProblemList_openjdk17-openj9.txt" \
14:04:22  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList-FIPS140_2.txt" \

- Add support for FIPS multi-version openjdk exclude

Signed-off-by: LongyuZhang <[email protected]>
@JasonFengJ9 JasonFengJ9 merged commit 546d182 into adoptium:master Dec 6, 2023
1 check passed
@llxia
Copy link
Contributor

llxia commented Dec 12, 2023

@LongyuZhang could back port this PR into https://github.com/adoptium/aqa-tests/tree/j9.0.42-release? Thanks

LongyuZhang added a commit to LongyuZhang/aqa-tests that referenced this pull request Dec 12, 2023
- Add support for FIPS multi-version openjdk exclude

Signed-off-by: LongyuZhang <[email protected]>
llxia pushed a commit that referenced this pull request Dec 12, 2023
- Add support for FIPS multi-version openjdk exclude

Signed-off-by: LongyuZhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants