Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate jck_custom to jck runtime, compiler and devtools custom #5087

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

sophia-guo
Copy link
Contributor

Close #5086

@sophia-guo
Copy link
Contributor Author

Eclipse Grinder: temurin-compliance/job/Grinder/4045/, 4046, 4049,4050,4051,4053

@sophia-guo sophia-guo requested a review from smlambert February 21, 2024 20:51
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I entirely understand the magic of how the CUSTOM_TARGET value from the Jenkins job gets set as the individual variables JCKRUNTIME_CUSTOM_TARGET, JCKCOMPILER_CUSTOM_TARGET and JCKDEVTOOLS_CUSTOM_TARGET, but presume it does somewhere (and see the successful grinders, so yay!).

Minor spelling correction requested, otherwise LGTM. We can manually update the text under the parameters in the temurin-compliance/job/Grinder/ and ci.adoptium.net/job/Grinder after this is merged (as typically Grinders are not regened from the template).

jck/README.md Outdated Show resolved Hide resolved
Co-authored-by: Shelley Lambert <[email protected]>
@sophia-guo sophia-guo merged commit 3492fbe into adoptium:master Feb 22, 2024
2 checks passed
@sophia-guo
Copy link
Contributor Author

Both temurin-compliance/job/Grinder/ and ci.adoptium.net/job/Grinder descriptions are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate jck_custom to jckruntime_custom, jckcompiler_custom and jckdevtools_custom
3 participants