Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jdk_beans on xlinux #5746

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Nov 12, 2024

  • Enable jdk_beans on xlinux except for java version 8 and 11

related: eclipse-openj9/openj9#20531

@@ -755,8 +755,21 @@
<testCaseName>jdk_beans</testCaseName>
<disables>
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/10757</comment>
<comment>https://github.com/eclipse-openj9/openj9/issues/20531 Only enabled on xlinux except for versions 8 and 11</comment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set url only

Comment on lines 763 to 770
<comment>https://github.com/eclipse-openj9/openj9/issues/20531</comment>
<version>8</version>
<impl>openj9</impl>
<platform>x86-64_linux</platform>
</disable>
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/20531</comment>
<version>11</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the disable versions, we can merge the two as [8-11], refer https://github.com/adoptium/TKG/blob/3ca1dc6782a8679ae8d7927e03fb3ac0a1e0ac5e/examples/jdkVersion/playlist.xml#L70 for more details.

@annaibm annaibm force-pushed the enableJDK_bean branch 2 times, most recently from 1ab3f79 to e5e79fc Compare November 12, 2024 15:36
@llxia
Copy link
Contributor

llxia commented Nov 12, 2024

FYI eclipse-openj9/openj9#20570 is fixing the xlinux issue. If it is merged, we can enable xlinux.

@pshipton
Copy link
Contributor

eclipse-openj9/openj9#20570 is now merged.

- Enable jdk_beans on xlinux for all java versions

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm marked this pull request as ready for review November 12, 2024 18:45
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 2761948 into adoptium:master Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants