Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jdk_beans on all linux #5808

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Dec 9, 2024

  • Enable jdk_beans on alinux, plinux, zlinux for all java versions

related: eclipse-openj9/openj9#20531

@llxia
Copy link
Contributor

llxia commented Dec 9, 2024

typo slinux -> zlinux

Comment on lines 757 to 761
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/20531</comment>
<impl>openj9</impl>
<platform>^((?!(x86-64_linux)).)*$</platform>
<platform>^(?!.*linux).*$</platform>
</disable>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To enable all linux, please remove L757 - L761

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtests are excluded in ProblemList.

@llxia
Copy link
Contributor

llxia commented Dec 9, 2024

In this case, the Adoptum master repo and branch and disabled.jdk_beans were used.

image

We are expecting Grinders to test PR.

@annaibm annaibm requested a review from llxia December 9, 2024 21:33
@llxia
Copy link
Contributor

llxia commented Dec 9, 2024

re #5808 (comment), please update PR description and commit message

- Enable jdk_beans on alinux, plinux, zlinux for all java versions

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm marked this pull request as ready for review December 9, 2024 21:49
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from LongyuZhang December 9, 2024 22:17
@LongyuZhang LongyuZhang merged commit 354b5b7 into adoptium:master Dec 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants