Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: switch to running builds in docker containers #1155

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Dec 3, 2024

We now have systems which are able to run builds in containers on Windows, similar to what we do for Linux.

Like s390x, these images cannot be publicly available so as a stop-gap until adoptium/infrastructure#3217 I'm using container images pre-created on the machine called win2022_notrhel_image specifically (the name including rhel is to block it from trying to issue a docker pull but going forward an option would be good).

Builds on the earlier work in:

Part of adoptium/infrastructure#3286

@sxa sxa requested a review from andrew-m-leonard December 3, 2024 15:03
Copy link

github-actions bot commented Dec 3, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa
Copy link
Member Author

sxa commented Dec 3, 2024

run tests quick 8,21

@github-actions github-actions bot added testing x64 Issues that affect or relate to the x64/x32 LINUX OS labels Dec 3, 2024
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sxa
Copy link
Member Author

sxa commented Dec 4, 2024

I've added the labels build and win2022 to the three active machines to allow the PR tests to run. Note that this would allow builds to be scheduled on these machines when they are not fed the docker parameters which is a risk (particularly before this is merged) but is consistent with what we have on x64 e.g. https://ci.adoptium.net/computer/dockerhost%2Dazure%2Dubuntu2204%2Dx64%2D1/ (This is possibly something we should look at separately across all such places where we use containers for building)

@sxa sxa requested a review from steelhead31 December 4, 2024 12:44
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sxa
Copy link
Member Author

sxa commented Dec 4, 2024

Merging this despite the tests not yet passing as they reached the end of the build phases and I want this active for the real EA builds this evening (which won't be able to schedule themselves otherwise). I also don't want to do any additional testing as the nodes are Burstable and I want them to build up some credit for the EA pipelines.

@sxa sxa merged commit fb9c821 into adoptium:master Dec 4, 2024
15 of 20 checks passed
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker jenkins-pipeline mac testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants