-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: switch to running builds in docker containers #1155
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
run tests quick 8,21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I've added the labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Merging this despite the tests not yet passing as they reached the end of the build phases and I want this active for the real EA builds this evening (which won't be able to schedule themselves otherwise). I also don't want to do any additional testing as the nodes are Burstable and I want them to build up some credit for the EA pipelines. |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
We now have systems which are able to run builds in containers on Windows, similar to what we do for Linux.
Like s390x, these images cannot be publicly available so as a stop-gap until adoptium/infrastructure#3217 I'm using container images pre-created on the machine called
win2022_notrhel_image
specifically (the name includingrhel
is to block it from trying to issue adocker pull
but going forward an option would be good).Builds on the earlier work in:
Part of adoptium/infrastructure#3286