Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbTests: Build bisheng as a test for RISC-V #2090

Closed
wants to merge 3 commits into from

Conversation

sxa
Copy link
Member

@sxa sxa commented Mar 28, 2021

Bisheng is a hotspot variant that builds natively on the platform for RISC-V, so select that if we're going a hotspot build test in qemuPlaybookCheck

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access) J9/ppc64le and hs/s390x (RISC-V QPC doesn't fully work yet)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@sxa sxa self-assigned this Mar 28, 2021
@karianna karianna added this to the March 2021 milestone Mar 29, 2021
@Willsparker
Copy link
Contributor

Do you have any documentation on Bisheng so I can read up? :-)

@sxa
Copy link
Member Author

sxa commented Apr 1, 2021

It's Huawei's port and was added via this issue: adoptium/temurin-build#2420

@sxa
Copy link
Member Author

sxa commented Apr 27, 2021

Assigning Will as co-owner of this since it can be used to fully test the RISC-V QPC support

@Willsparker
Copy link
Contributor

Ah okay- in that case, this PR is blocked by #2123 - I'll get on that now

@sxa
Copy link
Member Author

sxa commented Apr 30, 2021

Ah okay- in that case, this PR is blocked by #2123 - I'll get on that now

Yep that's pretty much why I've kept it in draft for now - awaiting the QPC test so we can verify it :-) Feel fre to take it out of draft as and when it's useful to do so

@Willsparker
Copy link
Contributor

Will do! Thanks

@karianna karianna modified the milestones: April 2021, May 2021 May 4, 2021
Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildJDK.sh will need an additional option to pass the variant - currently if building openj9, the buildVariant variable is set to nothing, and if building hotspot, it will pass --hotspot as an argument to buildJDK.sh. setting buildVariant to bisheng will just make buildJDK.sh error with unknown option.

@karianna karianna modified the milestones: May 2021, June 2021 Jun 6, 2021
@sxa sxa modified the milestones: June 2021, July 2021 Jul 5, 2021
@Haroon-Khel Haroon-Khel modified the milestones: July 2021, August Aug 3, 2021
@sxa sxa modified the milestones: August 2021, September 2021 Sep 23, 2021
@sxa sxa modified the milestones: September 2021, December 2021 Dec 1, 2021
@sxa sxa modified the milestones: December 2021, 2022-01 (January) Jan 6, 2022
@sxa sxa removed this from the 2022-04 (April) milestone May 24, 2022
@karianna
Copy link
Contributor

karianna commented Sep 7, 2022

@sxa Will need a rebase

@sxa
Copy link
Member Author

sxa commented Oct 31, 2023

I'm going to cancel this since Temurin now builds natively for JDK17+

@sxa sxa closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants