-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbTests: Build bisheng as a test for RISC-V #2090
Conversation
Do you have any documentation on Bisheng so I can read up? :-) |
It's Huawei's port and was added via this issue: adoptium/temurin-build#2420 |
Assigning Will as co-owner of this since it can be used to fully test the RISC-V QPC support |
Ah okay- in that case, this PR is blocked by #2123 - I'll get on that now |
Yep that's pretty much why I've kept it in draft for now - awaiting the QPC test so we can verify it :-) Feel fre to take it out of draft as and when it's useful to do so |
Will do! Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildJDK.sh
will need an additional option to pass the variant - currently if building openj9
, the buildVariant
variable is set to nothing, and if building hotspot, it will pass --hotspot
as an argument to buildJDK.sh
. setting buildVariant
to bisheng
will just make buildJDK.sh
error with unknown option.
Signed-off-by: Stewart X Addison <[email protected]>
@sxa Will need a rebase |
I'm going to cancel this since Temurin now builds natively for JDK17+ |
Bisheng is a hotspot variant that builds natively on the platform for RISC-V, so select that if we're going a hotspot build test in qemuPlaybookCheck
Checklist