Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbTests: Fixup buildJDK arguments in QPC & export buildJDK vars #2132

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

Willsparker
Copy link
Contributor

ref: #2121

Currently QPC is failing on a few platforms that should be stable. It was due to #1962 not updating the script to reflect buildJDK.sh's arguments. Amazing how the author of that PR didn't realise .. 👀 .

In my testing, I noticed that often the make-adopt-build-farm.sh wouldn't pickup on variables that were being set as part of buildJDK.sh. When the build scripts started defaulting most arguments, This just needed those variables exported. I've gone back to making openj9 the default as this tests more dependencies for our playbooks.

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access) QPC
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@Willsparker Willsparker added this to the April 2021 milestone Apr 15, 2021
@Willsparker Willsparker requested a review from sxa April 15, 2021 08:44
@Willsparker Willsparker self-assigned this Apr 15, 2021
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok so I'm happy for you to merge this if this has been tested and works, although I'm somewhat surprised this ever worked if the variables weren't being exported

@Willsparker
Copy link
Contributor Author

I'm somewhat surprised this ever worked if the variables weren't being exported

So am I ...

@Willsparker Willsparker merged commit 4a2a213 into adoptium:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants