-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Copy from the correct directory in Centos6 and Alpine dockerfiles #2761
Conversation
ref #2760 |
is passing SHA1 to ansible-playbook
is not needed? otherwise, still need to run "git rev-parse HEAD" which works with "copy . /ansible" ? |
@zdtsw The choice of passing
From #2751 (comment), we see that if we do copy the top level directory, theres no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed this somewhere but is there a reason why these changes are only on Alpine and CentOS6? Do we not require the same passing in of the SHAs on CentOS7/Ubuntu16.04? (And possibly my new Ubuntu 22.04 one!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sxa Ideally all build images should have it passed in and saved in the log file, but i've been focusing on alpine and centos6 recently since theyre in the github workflows and were stopping #2751 from getting merged. I can focus on the remaining build images too, but thats for a separate pr
Oh so it's because 2751 only modified those two and not the others. OK, but let's aim to get everything back in sync ASAP.
ref #2760
Revert
copy directory
changes that I made in https://github.com/adoptium/infrastructure/pull/2751/files#diff-cdadf2592f693c4816b592c519b913084ed2de4a238be6dbf42f75464798334bL7The changes to which level of the infra repo gets copied are obsolete in that pr since I was able to get the SHA to be passed in as a parameter. More so, these changes are causing a build failure on our alpine images in the centos7_docker_image_updater job
https://ci.adoptopenjdk.net/job/centos7_docker_image_updater/268/execution/node/63/log/
https://ci.adoptopenjdk.net/job/centos7_docker_image_updater/268/execution/node/77/log/