Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory: Update inventory file with new equinix machines #2841

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Inventory: Update inventory file with new equinix machines #2841

merged 1 commit into from
Dec 8, 2022

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Dec 1, 2022 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #2792

I have not added the new dockerstatic containers that are hosted on both of the new x64 dockerhost machines as we do not normally add those to the inventory file

karianna
karianna approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tellison
tellison approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@tellison tellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has Ansible Lint warnings

@tellison
Copy link
Contributor

tellison commented Dec 3, 2022

Approved, but not closed out in case you wish to also address linter warnings in this same PR

@Haroon-Khel
Copy link
Contributor Author

I am not seeing linter errors on my end

image

@Haroon-Khel Haroon-Khel merged commit 37bd201 into adoptium:master Dec 8, 2022
@Haroon-Khel Haroon-Khel deleted the update.inventory branch January 5, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellison tellison tellison approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haroon-Khel @tellison @karianna