Vagrant: Add Windows Server 2022 option to VPC #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VPC completed ok: https://ci.adoptium.net/job/VagrantPlaybookCheck/1773/ |
Vagrant performance tweak Vagrantfile alignments. Comment fix. Vagrant update Vagrantfiles
steelhead31
force-pushed
the
add_vpc_win2022
branch
from
47d9b80 to
0dbd98d
Compare
|
Interesting - I re-ran the ansible linter on another PR (https://github.com/adoptium/infrastructure/actions/runs/6864603825?pr=3250) and it seemed to go through ok. |
Yes, I've no idea why its suddenly failing today, I've identified the issue and have a suitable fix, which has been tested OK, but I've stuck it in a separate PR #3259 |
karianna
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3193
Implements a VPC option for Windows Server 2022, this requires a new Vagrant Box to match the standard VPC vagrant file naming ( Vagrantfile.win2022 ) and in particular an improvement to the MSVS_2017 installation from download role to mirror the installs of MSVS_2019 & MSVS_2019, in using Powershell to handle the installation rather than the command shell.
Checklist