-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aixPb: Install OpenSSL3 on Aix #3278
Conversation
ansible/playbooks/AdoptOpenJDK_AIX_Playbook/roles/openssl3/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_AIX_Playbook/roles/openssl3/tasks/main.yml
Show resolved
Hide resolved
dest: /tmp/ | ||
remote_src: false | ||
|
||
- name: cd into openssl directory and installp the binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it that fails without this PATH update? This feels a little indicative of a problem elsewhere?
Should probably have a comment about this for our future selves to be aware of the reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't necessarily fail if the PATH is not adjusted this way, but it will use /opt/freeware/bin/uname
somewhere in the install instead of /usr/bin/uname
which causes alot of
uname: invalid option -- 'W'
Try 'uname --help' for more information.
in the output. Again this isn't causing the install to fail but i'd rather it use the uname
it wants to use.
Ditto with the shell: PATH=/usr/bin/:$PATH && /usr/sbin/updtvpkg
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an argument for putting /usr/bin
ahead of /opt/freeware/bin
in the PATH but I am not too sure of the full scope of how that affects things
ansible/playbooks/AdoptOpenJDK_AIX_Playbook/roles/openssl3/tasks/main.yml
Show resolved
Hide resolved
A good run on test-osuosl-aix72-ppc64-2
|
FYI @AdamBrousseau |
ping @aixtools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since Adam is happy with this change :-)
Thanks for the other responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, I feel the use of VendorPages is wrong.
The proper way is to run a check - and say to an administrator that it failed. And an administrator should install it for you.
You could print a message saying where it can be loaded and point an admin to it there.
fyi: I would have loaded it long ago (as I had already downloaded it, made it into a nim resource to install/update with - but other settings that break normal AIX admin are not being addressed.
This is, imho, patchwork, not a structural approach to system administration.
I don't approve - but I won't try to block it either. Although, it took me forever to get rid of the need for previous vendor_files (that only works in your environment, by default) - and I am discouraged to see it reappearing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not the biggest fan of |
ref #3274