Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document the testing done in the infra repo #3291

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Dec 7, 2023

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #2502 (comment)

@github-actions github-actions bot added the doc label Dec 7, 2023

The workflow file can be found [here](https://github.com/adoptium/infrastructure/blob/master/.github/workflows/build.yml).

### QEMU Playbook Check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a duplciate of an earlier section but with different OS versions

Copy link
Contributor Author

@Haroon-Khel Haroon-Khel Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is the github workflow/action https://github.com/adoptium/infrastructure/blob/master/.github/workflows/build_qemu.yml. The earlier one is the jenkins job. I think both should be included in the docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Perhaps we should have a 'jenkins jobs' section like the Github one to have them categories appropriately?

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick set of suggestions that I'm making while on another call (so I may have more later) but this content is generally good!

Follow-on comments that don't affect this PR:

We should look at ditching Windows Server 2012 soon now that we are in the process of decommissioning all of those systems. Similarly Ubuntu 18.04 which is now out of normal support and we unlikely to provision more of them. Ubuntu 16.04 is in a slightly more unusual state because we still build on that as a base for our 32-bit arm builds, although obviously VPC is purely x64.
NOTE: We still have some in static docker containers of Ubuntu pre -20 for test, although they're not generated from the playbooks anyway)
Fedora 35 is also our of support, and we should probably look at switching that up to Fedora 40 when it is released in April.

docs/Testing.md Outdated Show resolved Hide resolved
docs/Testing.md Outdated Show resolved Hide resolved
docs/Testing.md Outdated Show resolved Hide resolved
- [MacOS 11](https://github.com/adoptium/infrastructure/blob/master/.github/workflows/build_mac.yml)
- [Windows 2019 and 2022](https://github.com/adoptium/infrastructure/blob/master/.github/workflows/build_wsl.yml)

### Docker Build Images
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth noting that these two actions perform a subset of the required build platforms which are pushed from jenkins and this is covered in https://github.com/adoptium/infrastructure/blob/master/FAQ.md#what-about-the-builds-that-use-the-dockerbuild-tag

@sxa sxa added this to the 2023-12 (December) milestone Dec 7, 2023
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the suggestions :)

docs/Testing.md Outdated Show resolved Hide resolved
Haroon-Khel and others added 4 commits December 11, 2023 18:02
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Scott Fryer <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you decide whether to implement the changes or not, but overall I'll give an approval so you don't have to wait for me again :-)


The workflow file can be found [here](https://github.com/adoptium/infrastructure/blob/master/.github/workflows/build.yml).

### QEMU Playbook Check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Perhaps we should have a 'jenkins jobs' section like the Github one to have them categories appropriately?

docs/Testing.md Outdated Show resolved Hide resolved
docs/Testing.md Outdated Show resolved Hide resolved
Haroon-Khel and others added 2 commits December 12, 2023 11:34
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit 2e15792 into adoptium:master Dec 12, 2023
4 checks passed
@Haroon-Khel Haroon-Khel deleted the ssdf.doc branch December 14, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants