-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPb: Update Centos7 image with patch & texinfo to enabled building of devkit #3293
Conversation
… of devkit Signed-off-by: Andrew Leonard <[email protected]>
VPC job: https://ci.adoptium.net/job/VagrantPlaybookCheck/1824/ - Good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments to indicate the reason for these additions e.g. "For devkit creation", similar to the one on strace so we don't lose track of why things that aren't directly related to the build are in here.
Also we need to have an equivalent change in the RHEL.yml that we can test on RHEL7 for s390x.
…uilding of devkit Signed-off-by: Andrew Leonard <[email protected]>
@sxa added comment and RedHat.yml update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks (Noting that VPC won't check RHEL specifically but I would expect it to be good and consistent with CentOS)
Fixes #3289
DevKit creation needs:
Checklist