Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPb: Update Centos7 image with patch & texinfo to enabled building of devkit #3293

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Dec 7, 2023

Fixes #3289

DevKit creation needs:

  • "patch" as DevKit patches certain downloads
  • "texinfo" as DevKit build of binutils needs this to build
Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@andrew-m-leonard andrew-m-leonard self-assigned this Dec 7, 2023
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Dec 7, 2023

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to indicate the reason for these additions e.g. "For devkit creation", similar to the one on strace so we don't lose track of why things that aren't directly related to the build are in here.
Also we need to have an equivalent change in the RHEL.yml that we can test on RHEL7 for s390x.

@andrew-m-leonard andrew-m-leonard requested a review from sxa December 8, 2023 16:43
@andrew-m-leonard
Copy link
Contributor Author

@andrew-m-leonard
Copy link
Contributor Author

Please add comments to indicate the reason for these additions e.g. "For devkit creation", similar to the one on strace so we don't lose track of why things that aren't directly related to the build are in here. Also we need to have an equivalent change in the RHEL.yml that we can test on RHEL7 for s390x.

@sxa added comment and RedHat.yml update

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks (Noting that VPC won't check RHEL specifically but I would expect it to be good and consistent with CentOS)

@andrew-m-leonard andrew-m-leonard merged commit 42de354 into adoptium:master Dec 11, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

patch and texinfo required in centos7_build_image to build linux jdk21u DevKit
3 participants