-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Fix insecure downloads discovered from TrailOfBits Audit #3329
Conversation
VPC Completed OK: https://ci.adoptium.net/job/VagrantPlaybookCheck/1827/ - except for Ubuntu, fixed and completed below. Ubuntu VPC: OK All changes have been tested locally and have worked ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks probably ok, although the SLES ones won't have been tested and we should verify that they will work on a SLES image first since the certs on the older SLES may have problems. Hadn't realised we had a download of an IBM Java on SLES11... Presumably because that version needed an older glibc ...
I'll run some tests on a SLES docker image, I did manage a test on a SLES 12.3 x64 vagrant box, with a custom written playbook, that simply downloads the file with those options, but I'll try running the playbook on some additional docker SLES12 & SLES15 s390x containers or similar. |
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/freemarker/tasks/main.yml
Outdated
Show resolved
Hide resolved
Tests on SLES12 & SLES15 docker containers ok for the changed element of the Java download, for SLES12, there are many other issues related to the lack of official repositories, but these are known issues, with SLES12 being end of life. |
Fix issues identified in ToB #4
Fixes #3324
Checklist