Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPB: Fix insecure downloads discovered from TrailOfBits Audit #3329

Merged
merged 11 commits into from
Jan 8, 2024

Conversation

steelhead31
Copy link
Contributor

Fix issues identified in ToB #4

Fixes #3324

Checklist

@steelhead31
Copy link
Contributor Author

steelhead31 commented Jan 5, 2024

VPC Completed OK: https://ci.adoptium.net/job/VagrantPlaybookCheck/1827/   - except for Ubuntu, fixed and completed below.

Ubuntu VPC: OK
https://ci.adoptium.net/job/VagrantPlaybookCheck/1828/

All changes have been tested locally and have worked ok.

@steelhead31 steelhead31 requested review from sxa and Haroon-Khel January 5, 2024 16:16
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks probably ok, although the SLES ones won't have been tested and we should verify that they will work on a SLES image first since the certs on the older SLES may have problems. Hadn't realised we had a download of an IBM Java on SLES11... Presumably because that version needed an older glibc ...

@steelhead31
Copy link
Contributor Author

I'll run some tests on a SLES docker image, I did manage a test on a SLES 12.3 x64 vagrant box, with a custom written playbook, that simply downloads the file with those options, but I'll try running the playbook on some additional docker SLES12 & SLES15 s390x containers or similar.

@steelhead31
Copy link
Contributor Author

Tests on SLES12 & SLES15 docker containers ok for the changed element of the Java download, for SLES12, there are many other issues related to the lack of official repositories, but these are known issues, with SLES12 being end of life.

@steelhead31 steelhead31 merged commit 35cb82b into adoptium:master Jan 8, 2024
8 of 10 checks passed
@steelhead31 steelhead31 deleted the tob_secdl_fixes branch January 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insecure software download in Ansible playbooks
4 participants