-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Fix Insecure Downloads In RHEL/SLES playbooks. #3355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
This is still awaiting the OpenSuse fixes, and shouldn't be merged until completed. This PR has been raised for visibility. |
/thaw |
Pull Request unblocked - code freeze is over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of notes:
- Did you find something that required zlib-devel to be installed? With Use bundled zlib on all versions, not just 21 temurin-build#3459 the JDK should no longer require it for build purposes
- I didn't realise we still had 32-bit stuff being installed in here. Don't think it's something that adoptium uses (we've never built for 32-bit xlinux) but we should perhaps check with IBM (@AdamBrousseau @sej-jackson ?) to see if they still have a requirement for those and if not, consider stripping it out to reduce complexity here.
Happy to approve in the meantime especially to alleviate the initial concern.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/NVidia_Cuda_Toolkit/tasks/main.yml
Outdated
Show resolved
Hide resolved
…_Toolkit/tasks/main.yml Co-authored-by: Stewart X Addison <[email protected]>
I've tried both build and test without zlib ( building fails due to missing X11, ALSA & Fontconfig dependencies, ), of which the Fontconfig does have a dependency on zlib ( which isn't installed by default on SLES 12 at least ).. Im inclined to leave it for the moment, and do some further investigation. |
Fixes #3341 & #3147
Ref: Security Audit Issue TOB-5 issues identified with insecure downloads in SLES & RHEL
Checklist