Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Build on MacOS13 image in github workflow #3413

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Feb 23, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3203

@github-actions github-actions bot added the ghActions GitHub Actions label Feb 23, 2024
@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Feb 23, 2024

I've removed the adoptopenjdk10 install from the common task as it is causing failures in both of the mac builds, and jdk10 get installed during the adoptopenjdk_install role anyway

- name: Download JDK10 tarball when installer is not available (macOS)

@karianna
Copy link
Contributor

@Haroon-Khel GH Check fails...

@Haroon-Khel
Copy link
Contributor Author

Reran the macos builds, looks like the gpg signature check fails intermittently with no route to host when trying to look up keys on the https://keyserver.ubuntu.com/ server

@Haroon-Khel
Copy link
Contributor Author

The macos13 check passes

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit 8af3ee6 into adoptium:master Feb 26, 2024
9 of 11 checks passed
@Haroon-Khel Haroon-Khel deleted the macos13.githubworkflow branch February 26, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible ghActions GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants