Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible] Download cross-build jdk11u from CI #3433

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Mar 4, 2024

We don't want to rely on openjdk-11-jdk from Ubuntu 20.04 repositories, it's based on Zero VM and just too slow for use as boot/build JDK.

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

We don't want to rely on openjdk-11-jdk from Ubuntu 20.04 repositories,
it's based on Zero VM and just too slow for use as boot/build JDK.
@luhenry
Copy link
Contributor Author

luhenry commented Mar 4, 2024

@sxa @andrew-m-leonard @Haroon-Khel @karianna could I please get a review? Thank you!

@luhenry luhenry changed the title Download cross-build jdk11u from CI ansible: Download cross-build jdk11u from CI Mar 4, 2024
@luhenry luhenry changed the title ansible: Download cross-build jdk11u from CI [ansible] Download cross-build jdk11u from CI Mar 4, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now, although we should likely switch to another method (e.g. pulling the Temurin early access builds) once we've started building regularly.

@luhenry
Copy link
Contributor Author

luhenry commented Mar 4, 2024

@sxa once we have the regular builds on RISC-V, I'll make sure to start cleaning up all these little hacks that crept up as we were building support. That'll be one of these.

@karianna
Copy link
Contributor

karianna commented Mar 5, 2024

GH Action failures seem unrelated

@karianna karianna merged commit 9c47baa into adoptium:master Mar 5, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants