Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Add Alpine 320 Static Dockerfile #3648

Merged
merged 1 commit into from
Jul 12, 2024
Merged

docker: Add Alpine 320 Static Dockerfile #3648

merged 1 commit into from
Jul 12, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jul 2, 2024 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3605

@Haroon-Khel Haroon-Khel requested review from sxa and steelhead31 July 2, 2024 12:23
steelhead31
steelhead31 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

karianna
karianna requested changes Jul 3, 2024
View reviewed changes
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.alp320
RUN mkdir -p /usr/lib/jvm/jdk21 && tar -xpzf /tmp/jdk21.tar.gz -C /usr/lib/jvm/jdk21 --strip-components=1

# Install ant and ant-contrib.
RUN wget -O /tmp/ant.zip 'https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.9-bin.zip'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer 1.10.14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I disagree with this but I feel if we are going to upgrade the ant version we should have that as a separate issue and run it through appropriate testing

ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.alp320 Show resolved Hide resolved
@Haroon-Khel Haroon-Khel requested a review from karianna July 10, 2024 16:16
@karianna karianna merged commit bf78273 into adoptium:master Jul 12, 2024
18 checks passed
@Haroon-Khel Haroon-Khel deleted the alp320.dockerfile branch July 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
ansible docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Haroon-Khel @karianna @sxa @steelhead31