-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: improves Ant-Contrib
role compatibility
#3753
base: master
Are you sure you want to change the base?
Conversation
@mahdipub linter failures |
Given the comment above the line, This needs to be tested on Solaris before it can be approved. |
It helps improve `Ant-Contrib` role by replacing wget with get_url module. Also when extracting, on macos the `unarchive` module might fails as it asks for gtar but default macos tar is `bsdtar`. The workaround is to run it as command on macos machines. Signed-off-by: [email protected]
45d9d88
to
dd6d373
Compare
Thanks, that's resolved. |
Don't see Solaris as part of that run? |
😕 Solaris10 is in there and green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the runs failed but solaris passed.
It helps improve
Ant-Contrib
role by replacing wget with get_url module. Also when extracing, on macos theunarchive
module might fails as it asks for gtar but default macos tar isbsdtar
. The workaround is to run it as command on macos machines.Signed-off-by: [email protected]
Checklist