-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: adds become: true
to all kernel config related tasks
#3754
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment why
b67f8bd
to
d1bd103
Compare
Comment updated |
@Haroon-Khel @gdams I'd appreciate your input on this in case there's any chance if it causing problems inside our infrastructure. |
Do we have instances of it failing due to lack of privilege? |
Here is a sample failure.
|
@mahdipub Can you give some information about the environment where you are seeing this - are you running ansible to set up the machine locally and using a normal user that can elevate it's privileges with |
@sxa in provided output, I am running against a mac machine remotely (from my laptop) and the user as you said is not privileged and need sudo to escalate but has sudo rights. |
Sorry, I meant within the code :-) |
@Haroon-Khel Can you easily verify that this won't negatively impact our playbook executions from ansible? |
d1bd103
to
baecaa2
Compare
@mahdipub Have you signed the Eclipse CLA? That check seems to be failing. |
I did. I tried JIC once more and I got:
|
I dont think I can easily verify this. Unfortunately the macos pr check doesnt run
I think the changes are ok, since they ultimately give the playbook execution a privilege it is expecting (or should otherwise have when running those tasks) |
in macos, touching `/etc/sysctl.conf`, puting content in it or rebooting system is what needs scallated priviledge because most of the time ansible user does not have enought authority to do system changes and need to use sudo. Adding `become: true` guarantee that ansible will not fail due to priviledge issue. Signed-off-by: mahdi@ibm.com
baecaa2
to
91f1d38
Compare
I think the macos13 failure is unrelated, but not sure. |
Ive restarted the macos13 job |
It seems to be failing at a brew link stage? |
Actually it fails on common when installing |
in macos, touching
/etc/sysctl.conf
, puting content in it or rebooting system is what needs scallated priviledge because most of the time ansible user does not have enought authority to do system changes and need to use sudo. Addingbecome: true
guarantee that ansible will not fail due to priviledge issue.Signed-off-by: mahdi@ibm.com
Checklist