Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPb: Correct the condition on JDK17 alpine aarch64 install #3807

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 8, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Mistakenly put the wrong condition in #3805 causing the JDK17 install to skip x64 alpine

https://ci.adoptium.net/job/centos7_docker_image_updater/576/execution/node/116/log/

#9 807.4 TASK [adoptopenjdk_install : Install latest Adopt JDK17 if one not already installed (Linux/Alpine-Linux)] ***
#9 807.4 skipping: [localhost]
#9 807.4 

This should skip the JDK17 install only on aarch64 alpine. Its equivalent to (ansible_distribution != "Alpine" or ansible_architecture != "aarch64") which is also used in the playbook to prevent JDK11 and JDK8 from installing on alpine aarch64.

The Alpine3 aarch64 build image will still have its JDK17 bootjdk as mentioned here #3805 (comment)

To clarify: we install a GA boot jdk17 on alpine x64 and a ea jdk17 on alpine aarch64

@Haroon-Khel
Copy link
Contributor Author

The alpine3 github workflow should show it not skipping

@Haroon-Khel
Copy link
Contributor Author

The alpine3 github workflow should show it not skipping

#10 688.0 TASK [adoptopenjdk_install : Install latest Adopt JDK17 if one not already installed (Linux/Alpine-Linux)] ***
#10 697.5 changed: [localhost]
#10 697.5 

Works

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karianna karianna merged commit afb0e11 into adoptium:master Nov 10, 2024
11 of 12 checks passed
mahdipub pushed a commit to mahdipub/infrastructure that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants