-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added jdk21 config files for msft linux deb+rpm installers #742
Conversation
@jmjaffe37 Looks like failing tests, is that expected? |
@karianna it looks like the failing test is checking to see if this package can be downloaded on ubuntu 22.10, but I don't think we support that release. I will try to find the source code of the test for more info Edit: upon further inspection it seems that this test is passing in our AzDO pipeline. I am unsure why it would be passing there and failing here |
It seems to be erroring on this assertion. For only ubuntu kinetic, there is a non-zero exit code when doing |
When I ran these tests locally, the error logs tell me that there is an execution error Caused by: |
This issue seems to affect all debian installer creation processes, see this GHA run from my fork using this branch: https://github.com/jmjaffe37/openjdk-installer/actions/runs/6331915451 |
Also, here is a link to the last clean run of the PR checks: #723 There are only 5 closed PRs ahead of this one, so the hunt should be narrow. Even so, I glanced at those PRs and it feels like they should not have caused this error |
Looks like this is due to ubuntu Kinetic hitting EoL and shutting down servers this month. We have 2 options:
Edit: here is a PR that implements solution 1: #745 |
I would recommend 1 and send a note to the adoptium installer channel to that effect |
@karianna sorry for the typo in my previous comment (it is fixed now), I actually implemented a solution following option 1 in my PR |
looks like 21 fails but that's a race condition with your other PR I assume? |
aa4a6dc
to
23a9b4d
Compare
This branch was just rebased with the main branch so it should pass the PR checks now (since my ubuntu kinetic fix was merged) |
Co-authored-by: Luigi Montoya <[email protected]>
These files were used internally to get our release out