User can now specify regexes used to find binaries #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
Mar 4, 2024
karianna
approved these changes
Mar 5, 2024
gdams
approved these changes
Mar 6, 2024
douph1
reviewed
Apr 9, 2024
| -delimiter " " | ||
|
|
||
| IF %ERRORLEVEL% == 1 ( | ||
| ECHO ARCH %ARCH% not supported : valid values are any combination of : x64, x86-32, arm64 |
There was a problem hiding this comment.
"x86" is missing here.
(I don't know how x86 is different from x86-32 and why it as been added)
There was a problem hiding this comment.
x86 is the same as x86-32. Some vendors (like Microsoft) use x86 instead of x86-32 so this change helps vendors use this code without local modification
There was a problem hiding this comment.
Note, I updated this for you in my latest PR: #851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used regexes are now default parameter values. Also replaced some unwieldy cmd code with powershell script