fix(day14): C# - Assertion hide LanguageExt.Map preserve order issue #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HulinCedric
force-pushed
the
fix_day14_langext_solution
branch
from
de50f3c
to
dd5b291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
BeSomeisBeSome(string because = "", params object[] becauseArgs), so the usageBeSome(expectedResult)doesn't assert theexpectedResult.By changing with
Be(expectedResult)or more verboseBeSome().Which.Should().Be(expectedResult)orBeSome(s => s.Should().Be(expectedResult))the assertion of theexpectedResultis verified.This revealed an issue with usage of the
LanguageExt.Mapbecause of lack of order preservation in usage ofFirstOrDefault.