-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate VideoPlayer and BlockingVideoPlayer game state classes #2348
Merged
ivan-mogilko
merged 12 commits into
adventuregamestudio:master
from
ivan-mogilko:362--blockingvideostate
Mar 8, 2024
Merged
Separate VideoPlayer and BlockingVideoPlayer game state classes #2348
ivan-mogilko
merged 12 commits into
adventuregamestudio:master
from
ivan-mogilko:362--blockingvideostate
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-mogilko
added
context: code
fixing/improving existing code: refactor, optimise, tidy...
context: video (playback)
labels
Mar 6, 2024
ivan-mogilko
force-pushed
the
362--blockingvideostate
branch
2 times, most recently
from
March 7, 2024 12:34
cb08601
to
906f905
Compare
ivan-mogilko
force-pushed
the
362--blockingvideostate
branch
from
March 7, 2024 13:43
906f905
to
befebbd
Compare
ivan-mogilko
force-pushed
the
362--blockingvideostate
branch
from
March 7, 2024 16:06
befebbd
to
617743c
Compare
ivan-mogilko
force-pushed
the
362--blockingvideostate
branch
2 times, most recently
from
March 7, 2024 22:38
be218d5
to
b78c1b1
Compare
Ouf, I had to change few things in VideoPlayer compared to #2338, after finding some logical mistakes. But it seems working now. NOTE: I tested all video settings such as speed, looping etc by temporarily hardcoding them, because there's no script commands for these in ags v3.*. |
ivan-mogilko
force-pushed
the
362--blockingvideostate
branch
from
March 8, 2024 11:21
b78c1b1
to
86628c8
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a limited backport from #2338, containing only improved VideoPlayer class, but no changes to script API, and no global working thread for non-blocking videos. Its main purpose is to keep code in branches at least somewhat consistent, but also make it easier to do improvements to video playback.
There's a potential issue with FLIC videos that I found. It looks like existing games that use FLIC has videos coded with 100 fps (!), but it's played at 60 fps as a effect from setting vsync in script, and that's how it matches the audio (which is played separately). This makes me concerned about maintaining compatibility with these games in case if a video will be run on a working thread on its true fps rate. I suppose this could be worked around by running the FLICs in manual mode using NextFrame() call from the main thread, rather than starting it with Play(). This is possible because FLICs don't have any audio in them.
EDIT: fixed this, but used an easier method.