Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade & Add 3ds2 redirect/native #192

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

Kwok-he-Chu
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu commented Dec 15, 2023

Fix frontend values (10 -> 100)
Boys scout: Giving @service class

Refactor: HttpSession in @service class to save the donation token and original pspreference
Copy link
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, see my comment about DonationService. We should also make sure the E2E tests pass (maybe we could upgrade the web drop-in as part of a different issue).

Added try catch on controller level to handle errors
@Kwok-he-Chu Kwok-he-Chu merged commit ea74a69 into main Dec 20, 2023
11 checks passed
@Kwok-he-Chu Kwok-he-Chu deleted the add-3ds2-redirect-and-native branch December 20, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants