Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/authorisation adjustment example #193

Merged
merged 15 commits into from
Jan 8, 2024
Merged

Feat/authorisation adjustment example #193

merged 15 commits into from
Jan 8, 2024

Conversation

Kwok-he-Chu
Copy link
Contributor

Added authorisation adjustments in Java

@Kwok-he-Chu Kwok-he-Chu requested a review from gcatanese January 8, 2024 09:11
gcatanese
gcatanese requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, it is all looking good. I have left some comments in some files.
The last remark is the README that could be aligned to the new template (like in the Checkout example)

authorisation-adjustment-example/src/main/java/com/adyen/checkout/api/ApiController.java Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/api/ApiController.java Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/api/WebhookController.java Outdated Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/api/WebhookController.java Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/api/WebhookController.java Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/util/Storage.java Outdated Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/util/Storage.java Outdated Show resolved Hide resolved
authorisation-adjustment-example/src/main/java/com/adyen/checkout/util/Storage.java Outdated Show resolved Hide resolved
@Kwok-he-Chu Kwok-he-Chu requested a review from gcatanese January 8, 2024 15:33
@Kwok-he-Chu Kwok-he-Chu merged commit 7e9d44f into main Jan 8, 2024
13 checks passed
@Kwok-he-Chu Kwok-he-Chu deleted the feat/authorisation-adjustment-example branch January 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcatanese gcatanese gcatanese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kwok-he-Chu @gcatanese