Upgrade to Adyen.Web Dropin/Components V6 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved v5 to its own /_archive/v5 folder
gcatanese
requested changes
Dec 23, 2024
| - name: Start checkout-example-advanced container | ||
| run: docker run --rm -d --name checkout-example-advanced-v5 -p 8080:8080 -e ADYEN_API_KEY="${{ secrets.ADYEN_API_KEY }}" -e ADYEN_MERCHANT_ACCOUNT=${{ secrets.ADYEN_MERCHANT_ACCOUNT }} -e ADYEN_CLIENT_KEY=${{ secrets.ADYEN_CLIENT_KEY }} -e ADYEN_HMAC_KEY=${{ secrets.ADYEN_HMAC_KEY }} checkout-example-advanced-v5:latest | ||
| - name: Run testing suite | ||
| run: docker run --rm --name adyen-testing-suite -e PLAYWRIGHT_FOLDERNAME=advanced-checkout/v5 -e ADYEN_HMAC_KEY=${{ secrets.ADYEN_HMAC_KEY }} --network host ghcr.io/adyen-examples/adyen-testing-suite:main |
There was a problem hiding this comment.
Setting PLAYWRIGHT_FOLDERNAME=advanced-checkout/v5 is correct, but the E2E testing for Advanced Flow needs to be updated.
There was a problem hiding this comment.
This one has been updated, I've added the v6 e2e tests in the same e2e-checkout-advanced.yml-file
| @@ -1,105 +1,143 @@ | |||
| const clientKey = document.getElementById("clientKey").innerHTML; | |||
| const type = document.getElementById("type").innerHTML; | |||
| const { AdyenCheckout, Dropin } = window.AdyenWeb; | |||
There was a problem hiding this comment.
We used to have a single file adyenImplementation.js for drop-in and components, but now we probably want to create individual files (dropin.js, ideal.js, card.js, etc..) I think.
Similarly to the Vue implementation we can keep those separated.
checkout-example-advanced/src/main/resources/static/adyenImplementation.js
Outdated
Show resolved
Hide resolved
checkout-example-advanced/src/main/resources/static/adyenImplementation.js
Outdated
Show resolved
Hide resolved
Change holder name to "J. Smith"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the upgrade to Adyen.Web Dropin v6.x.x (frontend), see: https://github.com/Adyen/adyen-web/releases/tag/v6.6.0
Additional steps
Notes:
It currently only addresses "Drop-in", will add the Components initial review: