Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade buf yaml config and CI #14

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Jul 10, 2024

This PR upgrades the config for buf modules, fixing lint checks, and updating the CI to push the main module. The config file is upgraded to v2 (follows this guide). Ran buf lint and corrected the CEL expression on the Interval type. Uses buf-action config to run build, checks (lint, format, breaking), and push on each feature branch and main to the BSR. Please see commit-by-commit for a breakdown of the steps.

There are a couple of behaviour changes in this PR. This implements the default behaviour as described in the buf-action repo. Every push will now sync with the BSR. On pull requests checks will be run. On merging to main the deleted branch will be archived and the latest on main synced.

@emcfarlane emcfarlane requested a review from a team as a code owner July 10, 2024 16:02
Copy link
Contributor

@rofrankel rofrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

One nit: it looks like this PR also makes some unrelated formatting changes. I think the protos were previously clang-formatted with Google style. Think we can preserve that, so that this PR only has contentful changes?

proto/aep-type/aep/type/phone_number.proto Outdated Show resolved Hide resolved
@rambleraptor rambleraptor merged commit 32fab75 into aep-dev:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants