Add Field behavior #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
force-pushed
the
field_behavior
branch
from
167bd4e to
487257d
Compare
| // aep.protobuf.Timestamp expire_time = 1 | ||
| // [(aep.api.field_behavior) = OUTPUT_ONLY, | ||
| // (aep.api.field_behavior) = IMMUTABLE]; | ||
| repeated aep.api.FieldBehavior field_behavior = 1052 [packed = false]; |
There was a problem hiding this comment.
probably need a new field extension number?
| // Specifically denotes a field as optional. | ||
| // While all fields in protocol buffers are optional, this may be specified | ||
| // for emphasis if appropriate. | ||
| OPTIONAL = 1; |
There was a problem hiding this comment.
kind of hilarious that the aep protos themselves are not proto compliant. I kind of find FIELD_BEHAVIOR_OPTIONAL ugly myself, but I guess we don't want conflicts in generated libraries.
| option go_package = "aep.dev/api"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "FieldBehaviorProto"; | ||
| option java_package = "com.aep.api"; |
There was a problem hiding this comment.
probably needs to be fixed - no reason to not be consistent here, is there?
| option java_multiple_files = true; | ||
| option java_outer_classname = "FieldBehaviorProto"; | ||
| option java_package = "com.aep.api"; | ||
| option objc_class_prefix = "AEP"; |
toumorokoshi
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
aep.api.FieldBehavior