Objects #22
Merged
Objects #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
reviewed
Sep 9, 2024
toumorokoshi
requested changes
Sep 9, 2024
rambleraptor
force-pushed
the
objects
branch
from
fa97778 to
ff47610
Compare
|
Looks like test issue is just because the outputs aren't fully idempotent. |
rambleraptor
force-pushed
the
objects
branch
from
ff47610 to
1f11390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for adding nested properties. These are modeled as top-level messages (called 'Objects' in the schema) since that's how proto / OpenAPI would model them.
I'm expecting a lot of comments on this PR since it's both messy and needs to do a lot of refactoring.