Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): use buf plugins for lint and fixes for AEP compliance. #28

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

toumorokoshi
Copy link
Member

@toumorokoshi toumorokoshi commented Sep 16, 2024

Using buf plugins for linting is a more ergonomic approach, avoiding the need to manually clone googleapis.

api-linter was updated with fixes, so this change was just switching to buf lint and adding it to github actions: aep-dev/api-linter#93.

@toumorokoshi toumorokoshi marked this pull request as draft September 16, 2024 01:12
@toumorokoshi toumorokoshi force-pushed the yft/buf branch 2 times, most recently from b2f2b6a to 227827c Compare September 21, 2024 18:11
@toumorokoshi toumorokoshi marked this pull request as ready for review September 21, 2024 18:12
@toumorokoshi toumorokoshi force-pushed the yft/buf branch 3 times, most recently from 784e12f to 985e917 Compare September 21, 2024 18:51
Using buf plugins for linting is a more ergonomic approach, avoiding the 
need to manually clone googleapis.

Fixes to reach AEP compliance: 

- removing apply method as it is not an official AEP at the moment.
@toumorokoshi toumorokoshi merged commit 71f7d30 into aep-dev:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant