New type schema #29
Merged
New type schema #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
requested changes
Sep 17, 2024
| case *schema.Property_ArrayType: | ||
| return protoTypeArray(p.GetArrayType(), s, m) | ||
| default: | ||
| return nil, fmt.Errorf("reached outside of prototype switch statement.") |
There was a problem hiding this comment.
same comment as above case / switches - something a little more meaningful?
There was a problem hiding this comment.
Looks like this was resolved without a reply back - did you decide this was okay as is?
It's fine, just want to clarify.
Co-authored-by: Yusuke Tsutsumi <[email protected]>
Co-authored-by: Yusuke Tsutsumi <[email protected]>
Co-authored-by: Yusuke Tsutsumi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new type schema we discussed in the prior PR.
The autogenerated files should have no changes.