Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt AIP-205: Beta-blocking changes #138

Merged
merged 9 commits into from
May 15, 2024
Merged

Adopt AIP-205: Beta-blocking changes #138

merged 9 commits into from
May 15, 2024

Conversation

rofrankel
Copy link
Collaborator

No description provided.

@rofrankel rofrankel marked this pull request as ready for review March 14, 2024 18:12
@rofrankel rofrankel requested a review from a team as a code owner March 14, 2024 18:12
@rofrankel rofrankel requested a review from toumorokoshi March 14, 2024 18:12
@rofrankel rofrankel enabled auto-merge (squash) March 14, 2024 18:12
@rofrankel rofrankel linked an issue Mar 14, 2024 that may be closed by this pull request
Adopt AIP-0205 Beta-blocking changes #50
Closed
toumorokoshi
toumorokoshi requested changes Mar 16, 2024
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good! only thing I feel like we need to do is have aep.dev/beta-blocker redirect somewhere with an explanation. Otherwise LGTM.

aep/general/0205/aep.yaml Outdated Show resolved Hide resolved
aep/general/0205/aep.md.j2 Show resolved Hide resolved
aep/general/0205/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0205/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0205/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0205/aep.md.j2 Show resolved Hide resolved
@earth2marsh
Copy link
Contributor

I wonder if AEPs should have an opinion on the lifecycle of changes. Alpha/Beta is a fairly common approach, but is it really necessary for AEPs to adopt this AIP?

@rofrankel rofrankel requested a review from toumorokoshi March 18, 2024 19:19
toumorokoshi
toumorokoshi approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I figure you'll file that issue so no blocking comments.

@toumorokoshi
Copy link
Member

BTW note the lint error that's blocking auto-merge.

mkistler
mkistler approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

But I think the title should be fixed.

aep/general/0205/aep.md.j2 Outdated Show resolved Hide resolved
@rofrankel rofrankel merged commit b0cab34 into aep-dev:main May 15, 2024
1 of 2 checks passed
@rofrankel rofrankel deleted the beta-blocking-changes branch May 15, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkistler mkistler mkistler approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt AIP-0205 Beta-blocking changes
4 participants
@rofrankel @earth2marsh @toumorokoshi @mkistler