Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODE_OF_CONDUCT.md #160

Merged
merged 5 commits into from
May 3, 2024
Merged

Create CODE_OF_CONDUCT.md #160

merged 5 commits into from
May 3, 2024

Conversation

mkistler
Copy link
Contributor

Add the CNCF Code of Conduct to this repo.

Add the CNCF Code of Conduct to this repo.
@mkistler mkistler requested a review from a team as a code owner March 29, 2024 15:21
@mkistler mkistler requested a review from toumorokoshi April 5, 2024 19:11
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@toumorokoshi
Copy link
Member

My two cents on this @mkistler @rofrankel is that we should just adopt the whole document, or choose to not adopt it and grab a separate code of conduct.

Personally I err toward adopting the document - it'll smooth the entry into CNCF if that's indeed the right place, and it's also a well-established and audited COC.

@rofrankel
Copy link
Collaborator

My two cents on this @mkistler @rofrankel is that we should just adopt the whole document, or choose to not adopt it and grab a separate code of conduct.

Personally I err toward adopting the document - it'll smooth the entry into CNCF if that's indeed the right place, and it's also a well-established and audited COC.

I buy that for the one comment thread where you replied directly, but if we're not a CNCF project it seems odd for our CoC to mention the CNCF specifically.

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one nit.

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@mkistler mkistler merged commit d8d41c0 into main May 3, 2024
2 checks passed
@mkistler mkistler deleted the code-of-conduct branch May 3, 2024 11:51
Copy link
Contributor

@earth2marsh earth2marsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to be woefully late, but this LGTM. nice addition, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants